Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the base URL for relic images and removes the raiding fee for Dungeon 2. The changes migrate from the previous domain to a DuckDNS-hosted URL and make raiding free for players.
- Updates relic image base URL from
relics.thecrypt.gametothecryptassets.duckdns.orgfor mainnet deployments - Sets Dungeon 2 raiding fee to "0" (previously 0.01 ETH) to make raids free
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const initialBaseImageURL = (() => { | ||
| if (deployment.hre.network.name == "mainnet") { | ||
| return 'https://relics.thecrypt.game/'; | ||
| return 'https://thecryptassets.duckdns.org/'; |
There was a problem hiding this comment.
Using DuckDNS (a free dynamic DNS service) for production mainnet assets may pose reliability and availability risks. DuckDNS hostnames can expire if not renewed, and the service doesn't provide uptime guarantees suitable for production. Consider using a more reliable hosting solution with proper domain management for mainnet deployments.
Suggested change
| return 'https://thecryptassets.duckdns.org/'; | |
| if (process.env.RELIC_ASSETS_URL) { | |
| return process.env.RELIC_ASSETS_URL; | |
| } else { | |
| throw new Error("RELIC_ASSETS_URL environment variable must be set for mainnet deployments. Do not use DuckDNS for production assets."); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New base url for all whitelist minters (dungeons and competition)
Dungeon 2 fees are now 0